Bug. Every time I try to enter the character "&"...

« Back

1544 days, 6 hours, 15 minutes ago

Bug. Every time I try to enter the character "&"...

Bug. Every time I try to enter the character "&" (ampersand) into a planetary friendly code I break the client, it disconnects as soon as I switch to the next planet, and I have to exit and reenter the game in order to get it working again. Tried in both Firefox with scripts running and also in the latest Internet Explorer and no scripts and it behaves the same. This is similar to the one I grumbled about a few months back where it did the same thing if you tried to give a ship an order when it was in orbit over a planet that you had just ordered the construction of a starbase over.

Has this been documented elsewhere in the friendly code section or can someone else provide independent verification?

Regards,
DB

1544 days, 5 hours, 41 minutes ago

emork the lizard king

RE: Bug. Every time I try to enter the character "&"...

Verified with Firefox and no add-ons.

In my tests the disconnect happened when "&" was the first character of the friendly code and at least one other character followed.
So "&" or "ft&" didn't cause a disconnct but "&d" did.

1544 days, 5 hours, 37 minutes ago

emork the lizard king

RE: Bug. Every time I try to enter the character "&"...

Now I wonder if a Birdman can cause his opponents to disconnect. :)

1544 days, 5 hours, 9 minutes ago

RE: Bug. Every time I try to enter the character "&"...

quickfix: dont use '&'

1544 days, 5 hours, 2 minutes ago

RE: Bug. Every time I try to enter the character "&"...

> quickfix: dont use '&'

That's probably the correct fix as well. The '&' has special meaning in HTML, which is probably causing the problem.

I'm removing the '&' from the list of valid characters in the Friendly Code.

1544 days, 3 hours, 59 minutes ago

RE: Bug. Every time I try to enter the character "&"...

> I'm removing the '&' from the list of valid characters in the Friendly Code.

I removed the as well. Using any valid 3-character HTML command as the Friendly Code will cause confusion for the client, and could cause it to crash or disconnect.

I would like to suggest that someone update the client to not allow these characters to be entered.

1544 days, 3 hours, 46 minutes ago

RE: Bug. Every time I try to enter the character "&"...

I would use these characters:
©±Þª¥¾¹²³××
Is it possible?

1544 days, 3 hours, 21 minutes ago

RE: Bug. Every time I try to enter the character "&"...

> I would use these characters

Probably.

In theory, any character from the 8-bit Extended ASCII character set should work, if it doesn't have any special function. The three characters above have special functions within HTML, so they sometimes cause problems.

I don't expect that Joshua limited the input characters to 7-bit, but it could have been done (and still could be done).

I strongly doubt that UNICODE characters will work properly, but you're welcome to try. If you do, I'd like to hear about the results.

1544 days, 2 hours, 53 minutes ago

RE: Bug. Every time I try to enter the character "&"...

Heh. Let's test it, guys. Who wants to volunteer for a destruction test on the client's friendly code interface?

Just send the results to me or to @Whisperer, and we'll modify the documentation.

1544 days, 2 hours, 44 minutes ago

mcnimble

RE: Bug. Every time I try to enter the character "&"...

just put 3 arabic characters in the FC. Displays two of them. Could put the triplet in the name, shows all three. Then again, using right-to-left texts could be causing all kinds of other problems ;) planets.nu uses utf-8 (meta content), so unicode should at least be handled as such.

Exit, select game, shows the same. So it does not corrupt anything. Now Q is, would FC match, get ship surrendered, etc.

Do I dare keep it over a hostrun and see if the host blows up?

Note: if ampersand crashes something, I expect missing input sanitation and that means potential security risks. Not good. Could also be bad representation in the output, but that just opens up a different can of worms.

1544 days, 2 hours, 32 minutes ago

RE: Bug. Every time I try to enter the character "&"...

༼ ºل͟º༼ ºل͟º( ͡° ͜ʖ ͡°)ºل͟º ༽ºل͟º ༽

I have arrived... and I bring you dongers!

ᕕ( ᐛ )ᕗヽ༼ ຈل͜ຈ༼ ▀̿̿Ĺ̯̿̿▀̿ ̿༽Ɵ͆ل͜Ɵ͆ ༽ﾉᕕ[ ・ ▾ ・ ]ᕗ

1544 days, 2 hours, 15 minutes ago

RE: Bug. Every time I try to enter the character "&"...

@Mcnimble,

> if ampersand crashes something, I expect missing input sanitation and that means potential security risks. Not good.

In this particular instance (Friendly Code), I don't think it's all that bad, as there's not much you can do with three characters. It would be interesting to see what would happen with HTML in the name of a ship.

@Glyn,

> I have arrived

Tell someone who cares, if you can find them.

In other words, if you can't contribute something meaningful to the discussion, please feel free to watch, but please don't interrupt it with your meaningless comments (trolling).

1544 days, 2 hours, 12 minutes ago

RE: Bug. Every time I try to enter the character "&"...

> It would be interesting to see what would happen with HTML in the name of a ship.

It's stripped out.

1544 days, 2 hours, 7 minutes ago

RE: Bug. Every time I try to enter the character "&"...

@Whisperer: You really like violating Rule 1 don't you?

1544 days, 1 hours, 15 minutes ago

mcnimble

RE: Bug. Every time I try to enter the character "&"...

Mha, clicking on "kal'saul"s profile in our MvM game, get a complaint that account "kal" does not exist. Safe, but not the desired outcome :(

1543 days, 23 hours, 55 minutes ago

RE: Bug. Every time I try to enter the character "&"...

what can be done to use a single quote (aka apostrophe) in a ship name?

1543 days, 23 hours, 46 minutes ago

RE: Bug. Every time I try to enter the character "&"...

@Ghostwriter: You can vote on planets.uservoice.com

https://planets.uservoice.com/forums/136520-general/suggestions/7518748-bug-minor-client-ship-name-apostrophe-bug

1543 days, 23 hours, 36 minutes ago

RE: Bug. Every time I try to enter the character "&"...

voted. thanks for the link.